Hi,
ich hoffe, dass ihr mir wieder einmal helfen könnt. Nachstehende Skripte stammt aus einem Buch (!) und dennoch sind wieder Fehler drin. Ich wäre über eine Korrektur der Fehler sehr dankbar
, da ich sie selbst nicht finden kann.
PHP
<?php // enthält eigentlich keine Fehler, wird aber zum Testen benötigt
class db_mysql {
PROTECTED $host;
PROTECTED $user;
PROTECTED $pwd;
PROTECTED $insert_id;
PROTECTED $affected_rows;
PROTECTED $num_rows;
PROTECTED STATIC $connect;
PROTECTED STATIC $queries;
PROTECTED STATIC $connections;
PUBLIC function __construct($db) {
if (!is_resource(self::$connect)) {
self::$connect = mysql_connect($this->host, $this->user, $this->pwd);
++self::$connections;
}
mysql_select_db($db) or die("could not select database");
}
PUBLIC function prepare($str) {
return mysql_real_escape_string($str);
}
PUBLIC function execute($sql) {
++self::$queries;
$result = mysql_query($sql);
$this->affected_rows = mysql_affected_rows(self::$connect);
$this->num_rows = @mysql_num_rows($result);
if (isset($this->num_rows)) {
$i = 1;
while ($array[$i] = mysql_fetch_assoc($result)) {
++$i;
}
mysql_free_result($result);
unset($array[$i]);
return $array;
}
$this->insert_id = mysql_insert_id(self::$connect);
return true;
}
PUBLIC function insert_id() {
return $this->insert_id;
}
PUBLIC function affected_rows() {
return $this->affected_rows;
}
PUBLIC function num_rows() {
return $this->num_rows;
}
PUBLIC function queries() {
return self::$queries;
}
PUBLIC function connections() {
return self::$connections;
}
}
?>
Alles anzeigen
PHP
<?php // enthält Fehler, die ich absolut nicht nachvollziehen kann
class db extends db_mysql {
PROTECTED $host = "localhost";
PROTECTED $user = "usr";
PROTECTED $pwd = "pwd";
PUBLIC function __construct($db = "db") {
parent::__construct($db);
}
}
?>
PHP
<?php // enthält ebenfalls Fehler, z. B. html-Ausgabe an falscher Stelle
class management {
PUBLIC function __construct() {
if ($_GET['sent'] == 1) {
$action = $this->create_user();
$_POST['id'] = $action[1];
}
if ($_POST['sent'] == 2) {
$action = $this->save_user();
}
if ($_GET['sent'] == 3 && !empty($_GET['id'])) {
$action = $this->delete_user();
if (empty($action[0])) {
$_POST['id'] = $_GET['id'];
}
}
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>management</title>
</head>
<body>
<div><?php echo $this->form($action[2]); ?></div>
</body>
</html>
<?php
}
PROTECTED function form($message = false) {
if (isset($message)) {
$m .= $message;
}
// select user
$db = new db();
$result = $db->execute("SELECT * FROM login ORDER BY user");
if ($db->num_rows() > 0) {
$m .= '
select user to edit please</p>';
$m .= '<form action="'.$_SERVER['PHP_SELF'].'" method="post">';
$m .= '<fieldset>';
$m .= '<select name="id">';
for ($i = 1; $i <= count($result); $i++) {
$m .= '<option value="'.$result[$i]['id'].'"';
if ($_POST['id'] == $result[$i]['id']) {
echo ' selected="selected"';
}
$m .= '>'.$result[$i]['user'].'</option>';
}
$m .= '</select>';
$m .= '<input type="submit" name="submit" value="select user" />';
$m .= '</fieldset>';
$m .= '</form>';
unset($db);
}
// edit user
if (!empty($_POST['id'])) {
$db = new db();
$result = $db->execute("SELECT * FROM login WHERE id = ".$db->prepare($_POST['id']));
if ($db->num_rows() == 1) {
$m .= 'edit user '.$result[1]['user'].' please';
$m .= '<form action="'.$_SERVER['PHP_SELF'].'" method="post">';
$m .= '<fieldset>';
$m .= '<input type="hidden" name="sent" value="2" />';
$m .= '<input type="hidden" name="id" value="'.$result[1]['id'].'" />';
$m .= '<label for="user">user</label>';
$m .= '<input type="text" name="user" id="user" value="'.$result[1]['user'].'" size="45" maxlength="50" />';
$m .= '<label for="password">password';
if ($result[1]['password'] == "password") {
$m .= " (fill the field in so that the user can login)";
} else {
$m .= " (don't fill in if password doesn't change)";
}
$m .= '</label>';
$m .= '<input type="text" name="password" id="password" value="" size="45" maxlength="50" />';
$m .= '<label for="trait">trait</label>';
$m .= '<input type="text" name="trait" id="trait" value="'.$result[1]['trait'].'" size="45" maxlength="50" />';
$m .= '<label for="admin">admin</label>';
$m .= '<label for="no">no</label>';
$m .= '<input type="radio" name="admin" id="no" value="-1"';
if ($result[1]['admin'] == -1) {
$m .= ' checked="checked"';
}
$m .= ' />';
$m .= '<label for="yes">yes</label>';
$m .= '<input type="radio" name="admin" id="yes" value="1"';
if ($result[1]['admin'] == 1) {
$m .= ' checked="checked"';
}
$m .= ' />';
$m .= '<input type="submit" name="submit" value="save changes" />';
$m .= '</fieldset>';
$m .= '</form>';
$m .= '
[url=''.$_SERVER['PHP_SELF'].'?sent=3&id='.$result[1]['id'].'']delete user[/url]';
}
}
$m .= '[url=''.$_SERVER['PHP_SELF'].'?sent=1']create user[/url]</p>';
return $m;
}
PROTECTED function create_user() {
$sql = "INSERT INTO login () VALUES ()";
$db = new db();
$action = $db->execute($sql);
if ($db->insert_id() > 0) {
$message = "new user was created";
return array(true, $db->insert_id(), $message);
}
$message = "new user wasn't created. at first edit new created users and change their user names until you create a new user.";
return array(false, "", $message);
}
PROTECTED function save_user() {
if (!empty($_POST['password']) && (strlen($_POST['password']) < 6 || strlen($_POST['password']) > 12)) {
$message .= "the password hasn't the correct string length";
unset($_POST['password']);
return array(false, $_POST['id'], $message);
}
$db = new db();
$sql = "UPDATE login SET";
if (!empty($_POST['password'])) {
$password2 = md5($_POST['password']);
$sql .= " password = '".$db->prepare($password2)."',";
}
$sql .= " user = '".$db->prepare($_POST['user'])."',";
$sql .= " admin = '".$db->prepare($_POST['admin'])."',";
$sql .= " trait = '".$db->prepare($_POST['trait'])."',";
$sql .= " WHERE id = '".$_POST['id']."'";
$action = $db->execute($sql);
if (!empty($_POST['password']) && $db->affected_rows() != 1) {
$message .= "couldn't save the changes, old password is still valid";
return array(false, $_POST['id'], $message);
}
if (!empty($_POST['password']) && $db->affected_rows() == 1) {
$message .= "the new password (".$_POST['password'].") is valid now";
return array(true, $_POST['id'], $message);
}
$message .= "changes are successful";
return array(true, $_POST['id'], $message);
}
PROTECTED function delete_user() {
$db = new db();
$sql = "DELETE FROM login WHERE id = ".$db->prepare($_GET['id']);
$action = $db->execute($sql);
if ($db->affected_rows() == 1) {
$message = "delete user successfully";
return array(true, "", $message);
}
$message = "couldn't delete user";
return array(false, "", $message);
}
}
?>
Alles anzeigen
PHP
<?php
class access {
PROTECTED $timeout = 15;
PROTECTED $redirectlogout = '[url='/php/target.php']target[/url]';
PROTECTED $redirectlogin = '[url='/php/target.php']target[/url]';
PRIVATE $mode;
PUBLIC function __construct($mode = 1, $minauthorisation = 1) {
$this->mode = $mode;
if ($_POST['sentto'] == 2) {
$ret = $this->logout();
$ret[1] .= $this->redirectlogout;
}
if ($_POST['sentto'] == 1) {
$ret = $this->checklogin();
if ($this->mode == 2 && !empty($ret[0])) {
$ret[1] .= $this->redirectlogin;
}
}
if ($this->mode == 1) {
$ret = $this->checkauthorisation($minauthorisation);
}
if (!empty($ret[0])) {
$this->writeauthorisation();
}
if (empty($ret[0]) || $this->mode == 2 ||$this->mode == 3) {
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>access</title>
</head>
<body>
<div><?php
if (!empty($ret[1])) {
echo $ret[1];
}
if (empty($ret[0]) && $this->mode != 3) {
echo $this->formlogin();
}
if (empty($ret[0]) && $this->mode == 3) {
echo $this->formlogout();
}
if (empty($ret[0]) || $this->mode == 2 || $this->mode == 3) {
?>
</div>
</body>
</html>
<?php
die();
}
}
}
PROTECTED function checklogin() {
$db = new db();
$result = $db->execute("SELECT id, password, session, (UNIX_TIMESTAMP() - UNIX_TIMESTAMP(time)) as timestamp, time FROM login WHERE user = '".$db->prepare($_POST['user'])."'");
if ($db->num_rows() != 1) {
$message = "check your user name please";
return array(false, $message);
}
if (md5($_POST['password']) != $result[1]['password']) {
$message = "check your password please";
return array(false, $message);
}
if ($result[1]['session'] == session_id() && $result[1]['timestamp'] / 60 < $this->timeout) {
$message .= "you are already logged in as ".$this->user();
$_SESSION['sit'] = session_id();
$_SESSION['id'] = $result[1]['id'];
return array(false, $message);
}
if (!empty($result[1]['session']) && $result[1]['timestamp'] / 60 < $this->timeout) {
$message .= "somebody is already logged in with your user name";
return array(false, $message);
}
$db2 = new db();
$sql = "UPDATE login SET";
$sql .= " time = NOW(),";
$sql .= " session = '".session_id()."'";
$sql .= " WHERE id = '".$result[1]['id']."'";
$db2->execute($sql);
$_SESSION['id'] = $result[1]['id'];
$_SESSION['sit'] = session_id();
$message = "you were logged in as ".$_POST['user'];
return array(true, $message);
}
PROTECTED function formlogin() {
$m .= '<form action="'.$_SERVER['PHP_SELF'].'" method="post">';
$m .= '<input type="hidden" name="sentto" value="1" />';
$m .= '<label for="user">user</label>';
$m .= '<input type="text" name="user" id="user" value="'.$_POST['user'].'" size="45" maxlength="50" />';
$m .= '<label for="password">password</label>';
$m .= '<input type="password" name="password" id="password" value="" size="45" maxlength="50" />';
$m .= '<input type="submit" name="submit" value="login" />';
$m .= '</form>';
return $m;
}
PROTECTED function checkauthorisation($minauthorisation) {
if (empty($_SESSION['id']) || empty($_SESSION['sit'])) {
$message = "log in please";
return array(false, $message);
}
/* if (empty($_SESSION['sit'])) {
$message = "log in please";
return array(false, $message);
} */
$sql = "SELECT admin, session, time, (UNIX_TIMESTAMP() - UNIX_TIMESTAMP(time)) as timestamp FROM login WHERE id = ".$_SESSION['id']." AND session = '".$_SESSION['sit']."'";
$db = new db();
$result = $db->execute($sql);
if ($db->num_rows() != 1) {
$message = "you aren't logged in, log in please";
return array(false, $message);
}
if ($result[1]['timestamp'] / 60 > $this->timeout) {
$message = "your session id isn't valid because of your anergic state for a long time, log in again please";
return array(false, $message);
}
if ($result[1]['admin'] == -1 && $minauthorisation == 2) {
$message = "your aren't logged in as admin, so you haven't any access to this page";
return array(false, $message);
}
return array(true, "");
}
PROTECTED function writeauthorisation() {
if (!empty($_SESSION['id']) && !empty($_SESSION['sit'])) {
$sql = "UPDATE login SET";
$sql .= " time = NOW(),";
$sql .= " WHERE id = '".$_SESSION['id']."' AND session = '".$_SESSION['sit']."'";
$db = new db();
$result = $db->execute($sql);
}
}
PROTECTED function formlogout() {
$m .= '<form action="'.$_SERVER['PHP_SELF'].'" method="post">';
$m .= '<input type="hidden" name="sentto" value="2" />';
$m .= '<input type="submit" name="submit" value="logout" />';
$m .= '</form>';
return $m;
}
PROTECTED function logout() {
$sql = "UPDATE login SET";
$sql .= " time = 0,";
$sql .= " session = ''";
$sql .= " WHERE id = '".$_SESSION['id']."'";
$db = new db();
$result = $db->execute($sql);
if ($db->affected_rows() == 1) {
unset($_SESSION['sit']);
unset($_SESSION['id']);
$message = "you have logged out successfully";
} else {
$message = "you weren't logged in";
}
return array(true, $message);
}
PUBLIC function user() {
$sql = "SELECT user FROM login WHERE id = '".$_SESSION['id']."'";
$db = new db();
$result = $db->execute($sql);
if ($db->num_rows() == 1) {
return $result[1]['user'];
} else {
return false;
}
}
}
?>
Alles anzeigen
Gesamt soll die Verwaltung der User so aussehen.
PHP
<?php
session_start();
require_once("./db_mysql.php");
require_once("./db.php");
require_once("./management.php");
require_once("./access.php");
// $access = new access(1, 2);
new management();
?>
Login
PHP
<?php
session_start();
require_once("./db_mysql.php");
require_once("./db.php");
require_once("./management.php");
require_once("./access.php");
$access = new access(2);
?>
Logout
PHP
<?php
session_start();
require_once("./db_mysql.php");
require_once("./db.php");
require_once("./management.php");
require_once("./access.php");
$access = new access(3);
?>
Schutz
PHP
<?php
session_start();
require_once("./db_mysql.php");
require_once("./db.php");
require_once("./management.php");
require_once("./access.php");
$access = new access(1, 1);
?>
Inhalt der zu schützenden Seite
Ich denke, dass die aus dem Buch das Skript zu kompliziert an manchen Stellen gemacht haben und wer Lust hat, kann es gern vereinfachen, da ich es dann auch besser begreife. Ansonsten würde ich mich über ein paar Kommentare im Skript (bei den Fehler und/ oder Vereinfachungen) freuen, da ich schließlich etwas lernen möchte.
Vielen Dank für eure Hilfe ![]()